Thank you for your contribution.
- You are committing everything in a single commit - and the commit message is not descriptive.
- I would suggest creating a new branch, split your changes into several small commits and create a Pull Request, merge it to your master branch. As this will make your changes trackable, and easy to identify in the future.
- I haven't found any useful comments in your commit. Comments are useful in the future even for your self to review your code.
- There are some duplication code such as
checkParams
. - Each function should only does one single - single responsibility. For example, in your
checkParams
, you also console.log - which is not very good practice. isError
could be just one line of code - you could define as a function prototype.- In
setDatatable
you are directly setting HTML with CSS - which is mixing the presentation with logics - that is not recommended.. Try to use some JS frameworks e.g. Vue, React or, Angular.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
RE: MyDiceBot v2.0.0 is out - supporting YoloDice with BTC/LTC/ETH/DOGE NOW!