RE: RE: Introducing Steem Multiple Authority Manager
You are viewing a single comment's thread from:

RE: Introducing Steem Multiple Authority Manager

RE: Introducing Steem Multiple Authority Manager

Thank you for your contribution! Great work.

  1. You might want to check the input using steem.utils.validateAccountName currently, any invalid account names including the prefix @ will cause a TypeError: Cannot read property 'name' of undefined at f.database.getAccounts.then (app.js:1)error in the console - which is slient to users.
  2. In fact, would it be better if your login requires actual validation via steemconnect so that users won't have to type in WIF everytime? Currently, it looks to me the login function is a bit fake... Look, I wished I can do this: LOL
  3. I would love to see a few unit tests in such kind of project - and it will be great if you can use travis-ci.com to set up a build system to boost some confidence.
  4. It might be useful to consider using some front-end frameworks such as Vue or React, currently I can see you have some code mixing the presentation and logics using jQuery.

Great work!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

H2
H3
H4
3 columns
2 columns
1 column
2 Comments